Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add new_streaming #1898

Merged
merged 7 commits into from
Feb 8, 2025
Merged

test: Add new_streaming #1898

merged 7 commits into from
Feb 8, 2025

Conversation

luke396
Copy link
Member

@luke396 luke396 commented Jan 30, 2025

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli
Copy link
Member

Thanks @luke396 ! Can we also set this environment variable for at least one CI run?

@MarcoGorelli
Copy link
Member

thanks, now we see a couple of test failures

FAILED tests/expr_and_series/reduction_test.py::test_scalar_reduction_with_columns[polars[lazy]-0] - ValueError: left len(left)=1 != right len(right)=3
FAILED tests/group_by_test.py::test_group_by_categorical[polars[lazy]] - pyo3_runtime.PanicException: called `Option::unwrap()` on a `None` value

the first will be fixed in the upcoming polars release

the second we may need to xfail

@luke396
Copy link
Member Author

luke396 commented Jan 30, 2025

the first will be fixed in the upcoming polars release

the second we may need to xfail

Thanks for the explanation! I'll address the second point shortly.

Looks like we should merge this PR once Polars' new release is out!

FBruzzesi
FBruzzesi approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luke396 ! I just pushed a couple of commits since polars just made a release and I was excited to see it in action 😂

@MarcoGorelli any objection before merging this?

HighFivePipTheBeachCatGIF

@MarcoGorelli
Copy link
Member

thanks both!

@MarcoGorelli MarcoGorelli merged commit 22274d8 into narwhals-dev:main Feb 8, 2025
24 checks passed
@luke396 luke396 deleted the add-new-streaming branch February 9, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBruzzesi FBruzzesi FBruzzesi approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test: run test suite with new_streaming=True for Polars lazy
3 participants
@luke396 @MarcoGorelli @FBruzzesi